Drop support for Python 3.6 #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't enabled by dropping 3.6 per se, but was found by pyupgrader when running to adapt anything enabled by 3.7 (there was nothing else).
Just enable all the letters. Turns out we were missing N, so pep8-naming wasn't turned on.
These crept in while pep8-naming was inadvertently disabled.
SciPy 1.1 was the first to support Python 3.7, our current minimum Python. SciPy 1.2 gets us closer to our nominal 2 year support window and eliminates skipping some tests.
This gets us pre-built wheels suitable for testing for 3.7 CI. It also moves in line more with our support window and allows us to drop another test skip.
2 tasks
dcamron
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
We say we generally support the last two Python minors (though that was before they went to the 12 month update cycle). We left 3.6 so that 1.0 would reach more users. We need to drop 3.6 just to keep pace with our dependencies--and allow us to close out a bunch of dependabot updates. We also bump the minimum SciPy version; 1.1 was the minimum bump needed to get support for Python 3.7 (at least pre-built wheels). I went ahead and went to 1.2 since it was released December 2018 and allows us to eliminate skipping some tests on old versions.
This PR also takes care of some modernization, like more f-strings and using
pathlib.Checklist