New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify environment installation steps in CONTRIBUTING #1882
Conversation
Is it possible to capture in this PR as well, the addition of how to install the correct matplotlib for testing images? @dopplershift and I worked through this yesterday and it could be a separate PR, but seems like it could go naturally with this one that is already started. |
Yeah, I'm gonna come back and flesh this out a little more proper next week. We created this as a demo exercise with our interns this morning! |
87378dd
to
5122eba
Compare
5122eba
to
454ba36
Compare
454ba36
to
62b54a7
Compare
I essentially used this to create a new environment to test something using Python 3.7 and this now captures the needed elements to get started. The only think I didn't have in the environment was git, which wasn't installed in my base environment, so while it is not a dependency at all, is that something we want to capture in the docs? |
If this is to serve as "from zero to dev environment" (I think so) and we expect them to clone the repository for development (we do), then absolutely! I'll add and reference something about having git installed as a prerequisite. |
bf5f3d4
to
16fee71
Compare
16fee71
to
64995d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a couple things, but otherwise this looks great.
CONTRIBUTING.md
had some room to catch up on our environment specification process to be more in-line with how we have it set up for CI and to more fully encompass what a user's development environment setup might look like (and preempt some potential headaches.)