Minor simplifications for the IO code #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that += for bytearray is implemented efficiently (unlike strings)--originally this was even faster than extend(). Also update one last use of Struct() to unpack a single integer.
dopplershift
added
Area: IO
dcamron
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
It turns out that
+=forbytearrayis implemented efficiently (unlike strings)--originally this was even faster thanextend()(See this video. Also update one last use ofStruct()to unpack a single integer.I was kinda hoping this might get some minor performance gain, but alas, no such luck. The code is still better this way, though.