New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up declarative dir
and tab-completion
#1903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcamron
changed the title
Declarative tabbing
Clean up declarative Jun 8, 2021
dir
and tab-completion
dcamron
added
Area: Plots
Pertains to producing plots
Type: Enhancement
Enhancement to existing functionality
labels
Jun 8, 2021
dopplershift
requested changes
Jun 14, 2021
dcamron
force-pushed
the
declarative-tabbing
branch
from
June 24, 2021 18:03
710ba10
to
f3b5281
Compare
Can you also fix the message here to remove "string" while you're here? MetPy/src/metpy/plots/declarative.py Lines 691 to 692 in 3f08b77
|
dcamron
force-pushed
the
declarative-tabbing
branch
2 times, most recently
from
August 6, 2021 19:21
a53900a
to
b7ca6cc
Compare
Add MetPyHasTraits class with current goal of modifying `__dir__` attr from HasTraits.
dcamron
force-pushed
the
declarative-tabbing
branch
from
August 6, 2021 19:33
b7ca6cc
to
767e13a
Compare
dcamron
force-pushed
the
declarative-tabbing
branch
from
August 6, 2021 20:40
a92ef73
to
b2d6886
Compare
dopplershift
approved these changes
Aug 6, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches the
__dir__
inheritance oftraitlets.HasTraits
so that our classes indeclarative.py
hide any inherited names as well as any_
or__
names for users of declarative classes hoping for more helpful tab completion. These can still be discovered with the underlying types if necessary. Results: