Remove any Pint objects from METAR parser output #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23ccozad
added
Area: IO
tests/io/test_metar.py
Outdated
| """Test that there are no Pint quantities in dataframes created by parser.""" | ||
| # Test parse_metar_file() | ||
| input_file = get_test_data('metar_20190701_1200.txt', mode='rt') | ||
| df = parse_metar_file(input_file) |
There was a problem hiding this comment.
Could loop over df like:
for df in (parse_metar_file(input_file), parse_metar_to_dataframe(metar_str)):
...
23ccozad
force-pushed
the
metar_parser_object_bug
branch
from
97e5f4d
to
2b515c8
Compare
23ccozad
force-pushed
the
metar_parser_object_bug
branch
from
2b515c8
to
529048f
Compare
dopplershift
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After further review of #1918 with @dopplershift, we determined that Pint quantities were being used in
eastward_windandnorthward_windcolumns of dataframes coming out of the METAR parser functions, and this was causing problems down the road when it came to plotting wind barbs. In this PR, we change howeastward_windandnorthward_windare created so that they are floats instead of Pint objects. This should solve the original issue #1916 related to the nightly build failing.This PR also adds a new test that makes sure that none of the columns in the dataframes created by METAR parsers contain Pint quantities.
Checklist