Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_declarative.py #1932

Merged
merged 2 commits into from Jun 24, 2021
Merged

Update test_declarative.py #1932

merged 2 commits into from Jun 24, 2021

Conversation

abnsy
Copy link
Contributor

@abnsy abnsy commented Jun 23, 2021

Description Of Changes

A module or an import name is reimported multiple times. This can be confusing and should be fixed. Please refer to the occurrence message to see the reimported name and the line number where it was imported for the first time.

Checklist

  • Closes #xxxx
  • Tests added
  • Fully documented

#BUG RISK
A module or an import name is reimported multiple times. This can be confusing and should be fixed. Please refer to the occurrence message to see the reimported name and the line number where it was imported for the first time.
@CLAassistant
Copy link

CLAassistant commented Jun 23, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and cleaning this up! Would you be willing to remove the other duplicate that's on line 512 of the same file?

tests/plots/test_declarative.py Outdated Show resolved Hide resolved
@dopplershift dopplershift merged commit be68bb5 into Unidata:main Jun 24, 2021
@github-actions github-actions bot added this to the 1.1.0 milestone Jun 24, 2021
@dopplershift
Copy link
Member

Congrats on your first contribution to MetPy @albernsrya ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants