Set up isort #1947
Merged
Set up isort #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Area: Infrastructure
This matches our previous configuration as closely as possible. Most of the changes here either compress some lines or pick up a few imports that weren't quite right.
While it gives less useful output than flake8-import-order, flake8-isort by running isort uses our isort config. We can deal with the worse output by just having people run isort.
Only the last one mattered anyway, but it's better for that to be at the top of the file.
dcamron
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This sets up isort to match our current import style as closely as possible. Other than removing some blank lines (which still passes flake8), it's mostly just compressing some imports a little better. I've gone ahead and remove
flake8-import-orderfrom our plugin suite and replaced withflake8-isort. While the latter gives less useful output, it makes use of our isort config--and we can pretty much just ignore any output issues by running isort. This is easily set up withpre-commit, though the question of whether to usepre-commitin CI (or use https://pre-commit.ci) is still an open one.We can adjust change this isort config to something like
profile='black'if we ever decide to go in that direction. Alternative to #1530.Checklist