Absolute momentum units bug fix #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that units are provided to `u` and `v` when calculating normal_component.
23ccozad
added
Area: Calc
dopplershift
reviewed
Jul 6, 2021
src/metpy/calc/cross_sections.py
Outdated
Comment on lines
295
to
296
| u = u.metpy.convert_units('m/s') | ||
| v = v.metpy.convert_units('m/s') |
There was a problem hiding this comment.
Maybe change these to e.g. u.metpy.quantity()? Then the last line of the function could be:
return (norm_wind + f * distance).metpy.convert_units('m/s')
src/metpy/calc/cross_sections.py
Outdated
Comment on lines
304
to
305
| x = x.metpy.convert_units('meters') | ||
| y = y.metpy.convert_units('meters') |
There was a problem hiding this comment.
Could maybe just entirely eliminate these lines? Not quite sure.
There was a problem hiding this comment.
"It looks like removing them doesn't break any tests"... famous last words.
There was a problem hiding this comment.
😆 It's an "opportunity" to test better if that's the case. 😉
New test makes sure that absolute_momentum() works when using units from the xarray DataArray `units` attribute.
dopplershift
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements @jthielen's solution to issue Error in absolute_momentum (bug in normal_component?) #1948, which converts
uandvto m/s before passing tonormal_component().Refactors one line of
absolute_momentum(), but I'm not familiar with the absolute momentum calculation. I'm willing to include more refactoring in this PR, but I would need some more specific direction on what to adjust/remove.Checklist