Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added equation to relative_humidity_from_dewpoint #1978

Merged
merged 6 commits into from Jul 27, 2021

Conversation

lswenson
Copy link
Contributor

I find it useful to have the formula in the documentation so I added it to this function I was using.

I find it useful to have the formula in the documentation so I added it to this function I was using.
@CLAassistant
Copy link

CLAassistant commented Jul 22, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, we're always happy to have more equations in the docs. Just had a few suggestions to help this match the rest of the docs.

src/metpy/calc/thermo.py Outdated Show resolved Hide resolved
src/metpy/calc/thermo.py Outdated Show resolved Hide resolved
lswenson and others added 2 commits July 22, 2021 14:36
Co-authored-by: Ryan May <rmay31@gmail.com>
Co-authored-by: Ryan May <rmay31@gmail.com>
src/metpy/calc/thermo.py Outdated Show resolved Hide resolved
@lswenson
Copy link
Contributor Author

I'm happy to add equations to other docs. Would you like me to do that in this pull request or start new ones?

Copy link
Member

@dcamron dcamron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these last formatting tweaks and the PR! To answer your question, we will be releasing MetPy 1.1 later this week. We'd be glad to have this be a part of 1.1 if you want to call this one wrapped-up and get it submitted. We will always (now, soon, or later) be glad to receive any new PRs and further documentation enhancements you've got ready for us!

src/metpy/calc/thermo.py Outdated Show resolved Hide resolved
@dcamron dcamron added this to the 1.1.0 milestone Jul 26, 2021
@dopplershift dopplershift added Area: Docs Affects documentation Type: Enhancement Enhancement to existing functionality labels Jul 26, 2021
Co-authored-by: Drew Camron <mew2dude@gmail.com>
@lswenson
Copy link
Contributor Author

Sounds great!

@dcamron dcamron enabled auto-merge July 26, 2021 22:32
@dcamron dcamron merged commit 66e5f08 into Unidata:main Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Docs Affects documentation Type: Enhancement Enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants