Fix up Showalter Index calculation #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No API break since this has not been in a release yet.
dopplershift
added
Area: Calc
This was incorrectly lifting a surface parcel to the LCL calculated from the 850 point. Instead, eliminate all of the manual calculation and just use parcel_profile. The new values are with 1% of those from Wyoming.
dopplershift
force-pushed
the
showalter-fixup
branch
from
1a84ca5
to
65dd3c0
Compare
dcamron
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This was incorrectly lifting a surface parcel to the LCL calculated from the 850 point. Instead, eliminate all of the manual calculation and just use parcel_profile. The new values are with 1% of those from Wyoming--which is now what's used in the test (the original test value was off by 50% of the new value). Also fix the function parameter name (
dewpt->dewpoint) and clean up a bit of the docstring.Checklist