Add argument name check in preprocess_and_wrap, and fix dewpoint_from_specific_humidity #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthielen
added
Type: Bug
dopplershift
previously approved these changes
Aug 31, 2021
dopplershift
previously approved these changes
Aug 31, 2021
dopplershift
reviewed
Sep 1, 2021
…_specific_humidity
dopplershift
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Implements the argument name check suggested in #2069, and fixes the spelling error in the decorator on
dewpoint_from_specific_humidity.I'm marking this as closing #2069, but if the intent for #2069 was broader than just this particular function's issue, then I'll edit that out. Also, not sure where to log the suggestion to "audit" all the decorator usage for broadcasting order and the like.
Checklist
Fully documented