Matplotlib Updates #2179
Merged
Matplotlib Updates #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Area: Plots
dopplershift
force-pushed
the
matplotlib-3.5
branch
from
6f4d664
to
5c687e8
Compare
dopplershift
force-pushed
the
matplotlib-3.5
branch
from
5c687e8
to
79660cc
Compare
dopplershift
force-pushed
the
matplotlib-3.5
branch
4 times, most recently
from
acc386a
to
d329517
Compare
|
Ok, this is at least passing with the PyPI stack. Working on getting Conda testing packages for 3.5. |
dopplershift
force-pushed
the
matplotlib-3.5
branch
2 times, most recently
from
261613c
to
3abbd3e
Compare
dopplershift
force-pushed
the
matplotlib-3.5
branch
from
3abbd3e
to
21f5da1
Compare
Matplotlib 3.5 removes the `label` kwarg, so we need to follow suit.
While this is shorter than our desired 2 year support window, it's easier to do this than to handle different __init__ parameters for XTick across different versions.
Use `add_artist` instead of `add_collection` since Matplotlib as of 3.5 has started checking that objects passed to `add_collection` inherit from `Collection`, which `TextCollection` currently does not do.
For some reason these were plotting lines over themselves. Move the lines apart to make the test better.
Matplotlib 3.5 subtly changed artist draw order. These grid-like lines really need to be treated explicitly as such with zorder anyway.
Small thresholds got bumped up, but anything at 0.1 or higher got a new image.
Was failing. To avoid warnings about edges, just go ahead and calculation the correct quad edges.
dopplershift
force-pushed
the
matplotlib-3.5
branch
from
21f5da1
to
4ca5f7c
Compare
dcamron
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
labelkwarg fromXTick.__init__PlotGeometrycallingadd_collectionwith ourTextCollectionclass. The warning is triggered becauseTextCollectionisn't a subclass ofCollection--just calladd_artistinstead.This deals with failures in nightly build opened in #2108, but will require matplotlib >3.5.0rc1 since rc1 has a bug that results in some extraneous Cartopy map lines.
Checklist
- [ ] Tests added- [ ] Fully documented