More checks #265
Merged
More checks #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Area: Infrastructure
dopplershift
force-pushed
the
more-checks
branch
10 times, most recently
from
8f19cfd
to
be0fed0
Compare
Also explicitly configure codecov to report status in event of CI failure. This should fix codecov staying in pending state on failed builds (Fixes Unidata#240)
We don't have control over what these names should be--they need to override attributes named by matplotlib.
This will held standardize our imports.
Add flake8-bugbear, flake8-builtins, flake8-comprehensions, flake8-mutable, flake8-pep3101, and flake8-print. These should help catch some mistakes.
dopplershift
force-pushed
the
more-checks
branch
from
be0fed0
to
c1b5ea9
Compare
Remove unneeded list comps where the function can work with a generator expression. Also remove unneeded usages of print--make hexdump return string (for logging), and remove duplicated functionality from IOBuffer.
dopplershift
force-pushed
the
more-checks
branch
from
0b837aa
to
3979378
Compare
This makes them better tests of the export machinery, as well as insulates the tests to any possible moves within sub-packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will add a bunch more quality checks, but want to incrementally do this so that I can be sure CI is catching it. Starting by rolling flake8 back to a version that hasn't broken plugins...