New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix get_wind_components see also doc string #269
Conversation
Thanks for catching that! Can you click through on the clahub check above and accept our Contributor License Agreement? |
interesting. done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Not sure if that "interesting" is positive or not... 😏 |
I'm not sure either! Do you find that it scares away open source beginners? |
Unknown at this point; You're the third person outside Unidata I've asked. Nobody has had any reservations yet. Hopefully this does enough to explain it. Luckily, potential contributors have to get over the PR hurdle first before they see this front and center. 😁 I think the open source world is mixed on CLAs. I had to do one for CartoPy; unfortunately, there's a human in the loop there receiving email copies which has really held up the process. Also, UCAR's legal department thinks they're a good idea. |
Did you have any reservations about signing? |
No, I didn't have any personal reservations. I'm only asking because MetPy is one of my go-to libraries when I want to see how people in the python world are approaching problems that I need to solve for the solar PV modeling library that I help maintain. Thanks! |
The get_wind_components doc string's
See Also
section points to a non existent function. Here's a quick fix. Feel free to edit as you like.