Improve tests #274
Merged
Improve tests #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Area: Infrastructure
|
Need to check when pytest started allowing |
dopplershift
force-pushed
the
improve-tests
branch
3 times, most recently
from
864ed98
to
7a8bd3b
Compare
dopplershift
force-pushed
the
improve-tests
branch
5 times, most recently
from
e48f13e
to
bd2c547
Compare
This way we can check that their aggregate coverage through codecov is 100% and ensure that all tests are being executed.
This was causing differences in tests between Python 2 and 3.
Because builtin round behavior changed between Python 2 and 3, and matplotlib < 2.0 was using it in places, we need to monkey patch it to get consistent testing across Python versions.
This was throwing off PyCharm.
Update images to matplotlib 2.0. Also add verion-dependent thresholds. All of this (with the previous fixes) allows us to have much tighter tolerances.
It's really hard to run Python 3.3 with a matplotlib where we can have tight image test tolerances. Instead, run it alongside our 2.7 legacy build tests.
dopplershift
force-pushed
the
improve-tests
branch
from
571f367
to
a127242
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to make the text-based (station plot) tests much more robust than we have now.
Also testing out having our coverage checking include our actual tests files so that we ensure everything is being run.
A few more little things.