-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support floats in image_range #3028
Support floats in image_range #3028
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the PR is in good shape, just the one small linting issue and if we can get a second test to cover the use of plt.Normalize
directly, that would be great. Appreciate the submission @wxmann.
Addressed both in the latest commit. Thank you! |
Thanks for sending in the fix! |
Description Of Changes
Permits floats to be used in
image_range
declarative plot property. Previously, only integer values were allowed.If
image_range
is aplt.Normalize
instance, just returns that object. Previously,image_range
permittedplt.Normalize
instances to be set, but threw an exception in the plotting execution.Checklist