New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbol Gallery #304
Symbol Gallery #304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things:
- Rebase and reword all commit messages to remove 'WIP'
- Squish together the commits about the fontsize parameter
- No notebooks--remember, all examples are
.py
files now
The images themselves look great!
Once you commit the Do you want to take a crack at including the images in the docs for plotting themselves, or do you want to wait on that? |
I'll have a crack at it - I just left it in the notebook while playing and will kill all of that once I get the integration with mpl working. |
Ah, ok. Well in that case, sail on. (And if you just wan't feedback and not an in-depth review, put [WIP] in the title of the PR) |
Got it. I'll plug away and see where it gets. Hopefully can have it in the docs shortly. |
7c2dc8e
to
7309ddd
Compare
Oddly enough, this works, but the figure titles do not render. Something to look into. |
Any thoughts on how this makes the docs look? I'll clean up the history once we're tuned in. |
c95cc57
to
a7ccdf9
Compare
After merging #310 and a rebase, this should be passing tests and ready for final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you squash the commits to remove the image change?
Also, can you add a couple tests for the added features? The len(symbol_mapper)
code is completely uncovered, and it would be nice to have a test for the fontsize stuff as well.
5d01bc0
to
e982e61
Compare
e982e61
to
b06d87b
Compare
Show all possible symbols by plotting in the docstring of plot_symbol.
b06d87b
to
b39cfc2
Compare
So make the default threshold 0.105. It's a bit higher than I want, but I just don't feel like making a special threshold on windows. Should be plenty tight to catch problems, which is the real purpose. |
264dafa
to
ba4b896
Compare
Adding a symbol gallery per #166 - will make this into part of the docs instead of an example unless there's objection. Notebook for prototyping, but I'm pretty happy with the look of the output.