Raise exception if LCL does not converge #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
requested changes
Feb 27, 2017
|
You'll need: with pytest.raises(RuntimeError):
lcl(...) |
dopplershift
requested changes
Feb 27, 2017
metpy/calc/tests/test_thermo.py
Outdated
| @@ -159,6 +160,11 @@ def test_lcl(): | |||
| assert_almost_equal(lcl_pressure, 864.761 * units.mbar, 2) | |||
| assert_almost_equal(lcl_temperature, 17.676 * units.degC, 2) | |||
|
|
|||
metpy/calc/tests/test_thermo.py
Outdated
| def test_lcl_convergence(): | ||
| """Test LCL calculation convergence failure.""" | ||
| with pytest.raises(RuntimeError): | ||
| lcl_pressure, lcl_temperature = lcl(1000. * units.mbar, 30. * units.degC, |
There was a problem hiding this comment.
Don't even bother capturing the return values.
metpy/calc/tests/test_thermo.py
Outdated
| """Test LCL calculation convergence failure.""" | ||
| with pytest.raises(RuntimeError): | ||
| lcl_pressure, lcl_temperature = lcl(1000. * units.mbar, 30. * units.degC, | ||
| 20. * units.degC, max_iters=2) | ||
|
|
There was a problem hiding this comment.
Another blank here for pep8.
jrleeman
force-pushed
the
LCL_Convergence
branch
from
94a29a6
to
38de5a7
Compare
|
I will merge despite being "out of date" since the last PR to go in was just docs--so long as this passes cleanly. |
|
Appveyor failure was spurious...restarted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't converge in
max_iterwe should fail loudly. Addresses #317