Convert quantities to scalars before formatting #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After our conversation I realized we never decided exactly how we were going to work around this strange issue. We'll still have to check for units regardless. |
|
I thought it was:
|
jrleeman
force-pushed
the
StatonPlot_Units
branch
from
91094f1
to
d4b9ea4
Compare
|
Looks like as long as we call |
|
CLA is stuck for some reason--no need to worry about it. |
dopplershift
added a commit
to dopplershift/MetPy
that referenced
this pull request
Jan 10, 2020
So with pint's advances, it turns out `item()` no longer strips units. This is Unidata#330 come back for revenge. The right answer is to just drop units when calling `plot_parameter`. We don't want them, and there's no format code that will drop units; while one could be added, this wouldn't work with floats in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pint implementation of format will not take a non empty format string, so this would fail when units were included (#307). Currently solution is to check if there is a units attribute and turn it into a scalar.