EL calculation #338
Merged
EL calculation #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
reviewed
Mar 6, 2017
metpy/calc/tests/test_thermo.py
Outdated
| @@ -190,3 +190,12 @@ def test_equivalent_potential_temperature(): | |||
| t = 288. * units.kelvin | |||
| ept = equivalent_potential_temperature(p, t) | |||
| assert_almost_equal(ept, 315.9548 * units.kelvin, 3) | |||
|
|
|||
There was a problem hiding this comment.
Missed a blank line (for pep8)
dopplershift
reviewed
Mar 6, 2017
metpy/calc/tests/test_thermo.py
Outdated
|
|
||
| def test_el(): | ||
| """Test equilibrium layer calculation.""" | ||
| levels = np.array([959., 779.2, 751.3, 724.3, 700., 269.]) * units.mbar |
There was a problem hiding this comment.
These are indented at 5 spaces.
|
Should we have a test for the no EL case as well? Seems like a good idea. |
|
I think that's an important edge case to verify it works--have you even tried that? The existing 3 May 1999 data should suffice for this. |
|
Yes, I did try it on real data with no problems. I'll add a test now. |
jrleeman
force-pushed
the
EL_Calculation
branch
2 times, most recently
from
73b17d4
to
f2151c1
Compare
|
Weird about appveyor--I guess you need to resolve the merge conflict? |
jrleeman
force-pushed
the
EL_Calculation
branch
3 times, most recently
from
8bb3df6
to
ee564f2
Compare
dopplershift
approved these changes
Mar 7, 2017
metpy/calc/thermo.py
Outdated
| # If there is only one intersection, it's the LFC and we return None. | ||
| if len(x) <= 1: | ||
| return None, None | ||
|
|
There was a problem hiding this comment.
Can we nuke the extra blank line?
dopplershift
requested changes
Mar 7, 2017
metpy/calc/thermo.py
Outdated
| r"""Calculate the equilibrium level. | ||
|
|
||
| This works by finding the last intersection of the ideal parcel path and | ||
| the measured parcel temperature. If there is one or fewer intersections, there is |
There was a problem hiding this comment.
measured environmental temperature
dopplershift
approved these changes
Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls out the EL calculation from #322