GEMPAK performance updates #3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm ok with the change. Can you take a look and see if there is a major file type or scenario here that's not covered in our tests? It looks like 30% of the changes here don't get run by the tests. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Use `set` instead of `list` to hold possible elements within the GEMPAK file object. `set` has better performance when checking for element membership. This change also allowed for modifications to the looping done to unpack elements such that performace would be further increased. Adds climate surface files for testing. This also updates the surface file type detection that was producing incorrect results. String data was removed from unmerged sounding unpacking routine as this should not appear in those file types per GEMPAK documentation. Add additional tests to improve coverage.
dopplershift
approved these changes
Mar 14, 2024
dopplershift
added
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Use
setinstead oflistto hold possible elements within the GEMPAK file object.sethas better performance when checking for element membership. This change also allowed for modifications to the looping done to unpack elements such that performance would be further increased.