Unit message helper #377
Merged
Unit message helper #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some units (like inHg) have a problem with the fractional exponent and then being converted to dimensionless. Instead, manually ensure this before taking the power.
This can be used to decorate calculation functions, providing checking of the dimensionality of paramters and raising helpful messages when improper arguments are provided. This requires function signature support from Python >= 3.3. On Python 2.7, this decorator is a no-op at runtime, but provides no checking. Pint has its own `check` decorator, but unfortunately this doesn't provide very helpful error messages.
This should only be applying where it's not going to break API.
dopplershift
added
Area: Calc
|
Well, the "quality" checkers all hate this for stupid reasons. Ignore those. |
jrleeman
approved these changes
Mar 30, 2017
|
It's ready, but travis seems to be having issues 😭 |
|
Of course.... |
|
Looks like we're good to go here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a decorator that allows us to decorate functions with the dimensionality of arguments (as positional or keyword arguments):
Sane handling of positional and keyword arguments relies on function signature arguments added to the
inspectmodule in Python >= 3.3. Thus this isn't available on Python 2.7, and at run time this is a no-op there.Closes #175.