Shade area on SkewT #382
Merged
Shade area on SkewT #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
requested changes
Mar 31, 2017
metpy/plots/skewt.py
Outdated
| def shade_area(self, y, x1, x2=0, which='both', **kwargs): | ||
| r"""Shades areas of CAPE. | ||
|
|
||
| Shades areas where the parcel is warmer than the environment (areas of positive |
There was a problem hiding this comment.
Need to update the docstring--I don't think you ever went back after copy/pasting:
- Not just CAPE.
- No documentation of
which, mention p,T,T_parcel which aren't actually parameters.
jrleeman
force-pushed
the
SkewT_Shade_Area
branch
from
8fc58fa
to
f3c92ee
Compare
dopplershift
added
Area: Plots
|
Have tests written, #378 needs to merge first before they'll run. |
jrleeman
force-pushed
the
SkewT_Shade_Area
branch
6 times, most recently
from
16e69e2
to
f7deebf
Compare
jrleeman
force-pushed
the
SkewT_Shade_Area
branch
from
f7deebf
to
b2cf23b
Compare
jrleeman
force-pushed
the
SkewT_Shade_Area
branch
from
b2cf23b
to
856f79a
Compare
|
Last error is because |
Since these are good to have for our defaults now, need to backport them until we're ready to only depend upon matplotlib >= 2.0.
dopplershift
approved these changes
Apr 4, 2017
jrleeman
commented
Apr 4, 2017
|
One more to threshold better on 1.4. Lack of |
dopplershift
force-pushed
the
SkewT_Shade_Area
branch
from
fe56268
to
1e47457
Compare
These pass fine on 1.5 without it, so I'm just going to blame 1.4 cruftiness.
Might as well turn it on since we're running the tests anyways. This should help with some coverage numbers.
|
Well, since codecov just refuses to update here, but the status looks good on the site, I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A shader that works with masked arrays and provides nice defaults for CAPE and CIN shading. I added the convenience methods just because it's nice to have the names in there. So far I decided to stick with the dictionary of defaults. Open to change.