Storm Relative Helicity Improvements #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Oct 3, 2017
metpy/calc/tests/test_tools.py
Outdated
| heights, data = get_layer_heights(heights, 500 * units.m, data, with_agl=True, | ||
| interpolation=False, bottom=200 * units.m) | ||
| heights_true = np.array([0.2, 0.3, 0.4, 0.5, 0.6, 0.7]) * units.km | ||
| data_true = np.array([50, 60 , 70, 80, 90, 100]) * units.degC |
stickler-ci
reviewed
Oct 3, 2017
metpy/calc/tests/test_tools.py
Outdated
| heights_true = np.array([0.2, 0.3, 0.4, 0.5, 0.6, 0.7]) * units.km | ||
| data_true = np.array([50, 60 , 70, 80, 90, 100]) * units.degC | ||
| assert_array_almost_equal(heights_true, heights, 6) | ||
| assert_array_almost_equal(data_true, data, 6) |
dopplershift
requested changes
Oct 3, 2017
| *args : array-like | ||
| Atmospheric variable(s) measured at the given pressures | ||
| bottom : `pint.Quantity`, optional | ||
| The bottom of the layer |
|
Safe to ignore code climate on this one I believe. |
dopplershift
previously approved these changes
Oct 17, 2017
|
Multiprocessing issues within flake8? |
|
See #588. Once that goes green, you can rebase on it. |
|
Should be good to go pending LGTM |
dopplershift
approved these changes
Oct 19, 2017
dopplershift
added
Area: Calc
|
I know @mwilson14 was planning on a PR wrt this function, heads up that it's changed up some now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #576 - There was complication with
get_layerand some non-ideal testing/methods. This PR cleans up the docs, adds the functionget_layer_heightfor height only subsetting (get_layerrequires and interpolates in pressure space only).Testing now uses a triangular hodograph with a simple solution.
We may need to do some refactoring of
get_layer, but that likely doesn't belong here. Either way I'm sure we can still do some API tuning.