Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update returns of figure annotations #611

Merged
merged 1 commit into from Nov 7, 2017
Merged

Update returns of figure annotations #611

merged 1 commit into from Nov 7, 2017

Conversation

jrleeman
Copy link
Contributor

@jrleeman jrleeman commented Nov 7, 2017

Closes #609

  • add_timestamp now returns the text instance
  • _add_logo now returns the figimage instance.

@jrleeman jrleeman added this to the 0.7 milestone Nov 7, 2017
@dopplershift
Copy link
Member

I'm not sure how I feel about the fact that this change requires no changes to tests...

@dopplershift dopplershift added Area: Plots Pertains to producing plots Type: Enhancement Enhancement to existing functionality labels Nov 7, 2017
@jrleeman
Copy link
Contributor Author

jrleeman commented Nov 7, 2017

The only thing that would change is a check for return types which seems odd.

@dopplershift
Copy link
Member

Yeah, I guess so.

@dopplershift dopplershift merged commit 004db46 into Unidata:master Nov 7, 2017
@jrleeman jrleeman deleted the annotation_returns branch November 7, 2017 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
Area: Plots Pertains to producing plots Type: Enhancement Enhancement to existing functionality
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrleeman @dopplershift