Replace "View source" with "Improve this page" #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the ReadTheDocs 'breadcrumbs.html' template to include this link. The link in the docs will point to the Github source in "edit" mode (on the master branch). If the page is autogenerated, it will point to a new issue instead with the page name included in the title and some instructions in the body.
|
|
|
So, it turns out that Github doesn't allow editing a file based on a tag. So there is no way to point the editing to the version corresponding to the docs build, only to master. I don't think this is a big problem and is probably best. The only issue that might happen is if a file changes names on master. This would result in a 404. |
dopplershift
added
Area: Docs
dopplershift
approved these changes
Dec 8, 2017
|
@dopplershift it's my pleasure! I borrow a lot from the metpy design so it's the least I can do. |
|
It's terrifying to know that my design...sensibilities could be infecting other unsuspecting projects. 😱 😁 (Honestly, I'm flattered...) |
|
Infections aren't always bad :) |
|
Thanks @leouieda! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the ReadTheDocs 'breadcrumbs.html' template to include this link. The link in the docs will point to the Github source in "edit" mode (on the master branch). If the page is autogenerated, it will point to a new issue instead with the page name included in the title and some instructions in the body.
Fixes #673