Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: Change default dimension ordering for kinematics functions #698

Merged
merged 3 commits into from Jan 4, 2018
Merged

MNT: Change default dimension ordering for kinematics functions #698

merged 3 commits into from Jan 4, 2018

Conversation

dopplershift
Copy link
Member

@dopplershift dopplershift commented Jan 4, 2018 •
edited

We already promised that we were going to do this, so we probably should.

@dopplershift dopplershift added Area: Calc Pertains to calculations Type: API Change Changes to how existing functionality works Type: Maintenance Updates and clean ups (but not wrong) labels Jan 4, 2018
@dopplershift dopplershift added this to the 0.7 milestone Jan 4, 2018
@dopplershift
MNT: Change default dimension ordering for kinematics functions
1257aa1 
We already promised that we were going to do this, so we probably
should.
@dopplershift
MNT: Work around flake8-docstrings problem
00b82f0 
1.2.0 doesn't seem to like our code.
jrleeman
jrleeman approved these changes Jan 4, 2018
View reviewed changes
Copy link
Contributor

@jrleeman jrleeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - we'll need to be sure the author's list is updated before tagging today. We've had new contributors! I'll go ahead with this so CI can get running.

@dopplershift dopplershift merged commit d1a9cd6 into Unidata:master Jan 4, 2018
@dopplershift dopplershift deleted the default-order branch January 4, 2018 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrleeman jrleeman jrleeman approved these changes

Assignees
No one assigned
Labels
Area: Calc Pertains to calculations Type: API Change Changes to how existing functionality works Type: Maintenance Updates and clean ups (but not wrong)
Projects
None yet
Milestone
0.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dopplershift @jrleeman