Add angle_to_dir to convert angles to nearest direction #853

ahuang11 · 2018-05-17T21:28:15Z

Also, minor enhancement to make parse_angle handle pd.Series and np.array. Fixes problem with missing data too.

metpy/calc/tools.py

metpy/calc/tests/test_tools.py

metpy/calc/tools.py

ahuang11 · 2018-05-31T05:54:08Z

Need to add feature to handle missing data, or else it crashes on nan.

metpy/calc/tools.py

jrleeman · 2018-06-04T15:04:52Z

@ahuang11 Let us know if you get stuck anywhere on the CI failures. We have a known issue on 3.4, but will be dropping it shortly.

metpy/calc/tests/test_tools.py

metpy/calc/tools.py

ahuang11 · 2018-06-08T03:31:28Z

Okay I'm not too sure why those tests are failing; one has to do with Python 3.4, but the other two I'm confused.

ahuang11 · 2019-04-11T01:43:07Z

Not exactly sure why the tests are failing.

dopplershift · 2019-04-11T18:37:44Z

This is the relevant line from the logs:

ERROR - The following functions are missing from the override file metpy.calc.rst: angle_to_dir

What it means is that you need to add angle_to_dir under the appropriate heading in _templates/overrides/metpy.calc.rst so that the function shows up in the categorized reference guide for the calculations.

ahuang11 · 2019-04-24T03:10:23Z

I think this is ready to be reviewed

CLAassistant · 2019-06-28T21:35:44Z

All committers have signed the CLA.

zbruick

I think we're looking to get this PR into 0.11, so if you're still interested in working on this, I have a few suggestions to think about. It will also need to be rebased on master and conflicts resolved, as quite a bit has been merged in since this was originally written. Let us know if you have any questions and thanks for your work!

examples/calculations/Angle_to_Direction.py

metpy/calc/tests/test_calc_tools.py

metpy/calc/tools.py

metpy/calc/tests/test_calc_tools.py

zbruick

Thanks for the changes! Just a couple things to fix to get CI to pass. Also it doesn't looked like you've signed the CLA, which would need to be done before merging.

docs/_templates/overrides/metpy.calc.rst

metpy/calc/tests/test_calc_tools.py

dopplershift · 2019-08-28T22:09:36Z

I have ahuang11 in the CLA list. GitHub is showing some commits with a different icon, which I'm guessing it related to the CLA issue. Unfortunately, looking at the commit log here on my system, I cannot for the life of me find any difference. So we can just merge over CLA if necessary.

zbruick

Looks good now. I think we just need a rebase to squash down a bunch of these commits and then we'll be good to go.

Optimized parse_angle() for long list of directional strings. Move "from operator import itemgetter" up one line. Revise how DIR_DICT is initialized; will use BASE_DEGREE_MULTIPLIER more in another PR. Remove print in test_tools Add back extra line... Handle np.array and pd.Series for parse_angle() and add new angle_to_dir() Fix example heading section Add full=True example Imperative Mood and newline between import group Update templates doc Fix CI Add back year

zbruick

So the rebase went ok, except that the unused issue crept up again. Just remove this import and we should be good to go.

examples/calculations/Angle_to_Direction.py

zbruick

Just need to switch to the new function name in the example

examples/calculations/Angle_to_Direction.py

zbruick

Thanks for making that last change. All the checks are now passing so we're good to go, but there's just a small copyright conflict. Can you accept the one that lists all of the years this file has been updated?

zbruick

The CI errors are due to xarray releasing v0.13, which is being fixed in #1144.

zbruick

Codecov isn't reporting despite being sent on all coverage runs on Travis. It passed before so I'm not concerned about it. @dopplershift, can you merge over it?

ahuang11 requested review from dopplershift and jrleeman as code owners May 17, 2018 21:28

stickler-ci reviewed May 17, 2018

View reviewed changes

metpy/calc/tools.py Outdated Show resolved Hide resolved

metpy/calc/tools.py Outdated Show resolved Hide resolved

dopplershift added this to the 0.9 milestone May 17, 2018

stickler-ci reviewed May 18, 2018

View reviewed changes

metpy/calc/tests/test_tools.py Outdated Show resolved Hide resolved

metpy/calc/tests/test_tools.py Outdated Show resolved Hide resolved

metpy/calc/tools.py Outdated Show resolved Hide resolved

stickler-ci reviewed May 18, 2018

View reviewed changes

metpy/calc/tools.py Outdated Show resolved Hide resolved

dopplershift added Type: Feature New functionality Area: Calc Pertains to calculations labels May 18, 2018

stickler-ci reviewed Jun 2, 2018

View reviewed changes

metpy/calc/tools.py Outdated Show resolved Hide resolved

stickler-ci reviewed Jun 7, 2018

View reviewed changes

metpy/calc/tests/test_tools.py Outdated Show resolved Hide resolved

metpy/calc/tools.py Show resolved Hide resolved

metpy/calc/tools.py Outdated Show resolved Hide resolved

dopplershift modified the milestones: 0.9, 0.10 Aug 17, 2018

jrleeman modified the milestones: 0.10, 0.11 Dec 17, 2018

zbruick suggested changes Aug 27, 2019

View reviewed changes

zbruick suggested changes Aug 28, 2019

View reviewed changes

docs/_templates/overrides/metpy.calc.rst Outdated Show resolved Hide resolved

metpy/calc/tests/test_calc_tools.py Outdated Show resolved Hide resolved

zbruick previously approved these changes Aug 29, 2019

View reviewed changes

Add parse_angle() example to calculations page.

38d80f8

ahuang11 dismissed zbruick’s stale review via c3e2b9b August 30, 2019 02:03

ahuang11 force-pushed the master branch 2 times, most recently from c3e2b9b to 88e8cc5 Compare August 30, 2019 02:07

ahuang11 force-pushed the master branch from 14afd80 to 2366793 Compare August 30, 2019 02:09

zbruick suggested changes Aug 30, 2019

View reviewed changes

examples/calculations/Angle_to_Direction.py Outdated Show resolved Hide resolved

ahuang11 and others added 2 commits September 15, 2019 15:14

Merge branch 'master' into master

f17dbce

Remove unused import np

aaa58bc

zbruick suggested changes Sep 16, 2019

View reviewed changes

examples/calculations/Angle_to_Direction.py Outdated Show resolved Hide resolved

examples/calculations/Angle_to_Direction.py Outdated Show resolved Hide resolved

examples/calculations/Angle_to_Direction.py Outdated Show resolved Hide resolved

Fix method names

33da3f0

zbruick suggested changes Sep 17, 2019

View reviewed changes

Merge branch 'master' of https://github.com/Unidata/MetPy

788bb34

zbruick previously approved these changes Sep 18, 2019

View reviewed changes

Merge branch 'master' into master

4060374

dopplershift dismissed zbruick’s stale review via f93937c September 27, 2019 06:32

Merge branch 'master' into master

6116cec

dopplershift force-pushed the master branch from f93937c to 6116cec Compare September 27, 2019 07:36

zbruick approved these changes Sep 27, 2019

View reviewed changes

zbruick merged commit f377a48 into Unidata:master Sep 27, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add angle_to_dir to convert angles to nearest direction #853

Add angle_to_dir to convert angles to nearest direction #853

ahuang11 commented May 17, 2018 •

edited

ahuang11 commented May 31, 2018

jrleeman commented Jun 4, 2018

ahuang11 commented Jun 8, 2018

ahuang11 commented Apr 11, 2019

dopplershift commented Apr 11, 2019

ahuang11 commented Apr 24, 2019

CLAassistant commented Jun 28, 2019 •

edited

zbruick left a comment

zbruick left a comment

dopplershift commented Aug 28, 2019

zbruick left a comment

zbruick left a comment

zbruick left a comment

zbruick left a comment

zbruick left a comment

zbruick left a comment

Add angle_to_dir to convert angles to nearest direction #853

Add angle_to_dir to convert angles to nearest direction #853

Conversation

ahuang11 commented May 17, 2018 • edited

ahuang11 commented May 31, 2018

jrleeman commented Jun 4, 2018

ahuang11 commented Jun 8, 2018

ahuang11 commented Apr 11, 2019

dopplershift commented Apr 11, 2019

ahuang11 commented Apr 24, 2019

CLAassistant commented Jun 28, 2019 • edited

zbruick left a comment

Choose a reason for hiding this comment

zbruick left a comment

Choose a reason for hiding this comment

dopplershift commented Aug 28, 2019

zbruick left a comment

Choose a reason for hiding this comment

zbruick left a comment

Choose a reason for hiding this comment

zbruick left a comment

Choose a reason for hiding this comment

zbruick left a comment

Choose a reason for hiding this comment

zbruick left a comment

Choose a reason for hiding this comment

zbruick left a comment

Choose a reason for hiding this comment

ahuang11 commented May 17, 2018 •

edited

CLAassistant commented Jun 28, 2019 •

edited