Add instructions for adding a file to the cache #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
reviewed
Sep 5, 2018
CONTRIBUTING.md
Outdated
|
|
||
| ## Cached Data Files | ||
| MetPy keeps some test data, as well as things like shape files for US counties in a data cahce | ||
| supported by the pooch library. To add files to this, please ensure they are the minimum size. |
There was a problem hiding this comment.
"they are the minimum size" -> "they are as small as possible"?
kgoebber
reviewed
Sep 5, 2018
CONTRIBUTING.md
Outdated
|
|
||
| ## Cached Data Files | ||
| MetPy keeps some test data, as well as things like shape files for US counties in a data cahce | ||
| supported by the pooch library. To add files to this, please ensure they are the minimum size. |
There was a problem hiding this comment.
I would add that this command should be run in the same directory that contains the staticdata directory - just to make it clear.
leouieda
reviewed
Sep 5, 2018
CONTRIBUTING.md
Outdated
| @@ -200,6 +200,18 @@ to run only the test you just created for this step. | |||
|
|
|||
| For more information, see the `docs for mpl-test <https://github.com/astrofrog/pytest-mpl>`_. | |||
|
|
|||
|
|
|||
| ## Cached Data Files | |||
| MetPy keeps some test data, as well as things like shape files for US counties in a data cahce | |||
jrleeman
force-pushed
the
pooch_instructions
branch
from
ffe5aa6
to
1e3b13e
Compare
|
Ok - should be good to go unless anyone sees anything else! |
dopplershift
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there anything else that you would have found useful here @kgoebber? Adding instructions for putting files in the cache.