New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for requirements #947
Conversation
Rather than pinning to exact version including bug fix. Turns out we were already doing this for conda.
Tests were broken by matplotlib 3.0 due to our tests' use of old matplotlib style parameters. Main code was note affected.
Looks like a cross section issue in the gallery:
|
Ah, that one is matplotlib breaking cartopy (matplotlib/matplotlib#12288). I think we can fix it up by not using pyplot. |
This specifically fixes a problem between matplotlib 3.0 and CartoPy.
b419842
to
bd51daf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a mpl 3 hold machine issue from scipy.spatial 2d tri plotting. Relevant scipy code:
if tri.points.shape[1] != 2:
raise ValueError("Delaunay triangulation is not 2-D")
ax.plot(tri.points[:,0], tri.points[:,1], 'o')
ax.triplot(tri.points[:,0], tri.points[:,1], tri.simplices.copy())
_adjust_bounds(ax, tri.points)
bd51daf
to
2a7d7f2
Compare
Right, saw that last night--must have missed one. Maybe now it will pass? 馃檹 |
Still a no go |
2a7d7f2
to
2c575b7
Compare
Once more into the breach... |
2c575b7
to
fab0e1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it!
environment.yml
was already doing this (by accident IMO), but nowsetup.py
will allow too.MultipleLocator
(BUG: Fix typo in view_limits() for MultipleLocator聽matplotlib/matplotlib#12313) broke the tests--but this path is only triggered with non-default matplotlib style (which happens to be used by pytest-mpl). Just adjusting our tests is good enough to avoid the bug.I expect our tests to pass with this PR.