Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for requirements #947

Merged
merged 4 commits into from Sep 28, 2018
Merged

Update for requirements #947

merged 4 commits into from Sep 28, 2018

Conversation

dopplershift
Copy link
Member

  • Update pinning for pooch 0.1.* I think we can trust bug fix releases. 馃榿 Also, apparently our environment.yml was already doing this (by accident IMO), but now setup.py will allow too.
  • Tweak tests to pass on matplotlib 3.0. Small bug in a certain path of MultipleLocator (BUG: Fix typo in view_limits() for MultipleLocator聽matplotlib/matplotlib#12313) broke the tests--but this path is only triggered with non-default matplotlib style (which happens to be used by pytest-mpl). Just adjusting our tests is good enough to avoid the bug.

I expect our tests to pass with this PR.

Rather than pinning to exact version including bug fix. Turns out we
were already doing this for conda.
Tests were broken by matplotlib 3.0 due to our tests' use of old
matplotlib style parameters. Main code was note affected.
@dopplershift dopplershift added this to the 0.9.2 milestone Sep 27, 2018
@dopplershift dopplershift added Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Maintenance Updates and clean ups (but not wrong) Area: Tests Affects tests labels Sep 27, 2018
@jrleeman
Copy link
Contributor

Looks like a cross section issue in the gallery:

Warning, treated as error:
/home/travis/build/Unidata/MetPy/examples/cross_section.py failed to execute correctly: Traceback (most recent call last):
  File "/home/travis/build/Unidata/MetPy/examples/cross_section.py", line 93, in <module>
    inline_spacing=8, fmt='%i', rightside_up=True, use_clabeltext=True, alpha=0.6)
  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/matplotlib/pyplot.py", line 2496, in clabel
    return gca().clabel(CS=CS, *args, **kwargs)
TypeError: clabel() got multiple values for argument 'CS'

@dopplershift
Copy link
Member Author

Ah, that one is matplotlib breaking cartopy (matplotlib/matplotlib#12288). I think we can fix it up by not using pyplot.

This specifically fixes a problem between matplotlib 3.0 and CartoPy.
@dopplershift dopplershift force-pushed the update-reqs branch 4 times, most recently from b419842 to bd51daf Compare September 28, 2018 06:06
Copy link
Contributor

@jrleeman jrleeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a mpl 3 hold machine issue from scipy.spatial 2d tri plotting. Relevant scipy code:

 if tri.points.shape[1] != 2:
        raise ValueError("Delaunay triangulation is not 2-D")

    ax.plot(tri.points[:,0], tri.points[:,1], 'o')
    ax.triplot(tri.points[:,0], tri.points[:,1], tri.simplices.copy())

    _adjust_bounds(ax, tri.points)

@dopplershift
Copy link
Member Author

Right, saw that last night--must have missed one. Maybe now it will pass? 馃檹

@jrleeman
Copy link
Contributor

giphy

@jrleeman
Copy link
Contributor

Still a no go

@dopplershift
Copy link
Member Author

Once more into the breach...

Copy link
Contributor

@jrleeman jrleeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Area: Tests Affects tests Type: Maintenance Updates and clean ups (but not wrong)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants