Deprecation check #948
Merged
Deprecation check #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrleeman
added
the
Area: Infrastructure
stickler-ci
reviewed
Sep 28, 2018
metpy/testing.py
Outdated
| def wrapper(*args, **kwargs): | ||
| with pytest.warns(MetpyDeprecationWarning): | ||
| return func(*args, **kwargs) | ||
| return wrapper |
jrleeman
force-pushed
the
deprecation_check
branch
from
a1bab07
to
5e7a6ee
Compare
jrleeman
force-pushed
the
deprecation_check
branch
from
5e7a6ee
to
766fde9
Compare
|
Failing as the doctests hit deprecation warnings everywhere and we can't exactly decorate those.... Hmmm. Might have to specify the warning filter in the CI configs 😭 |
jrleeman
force-pushed
the
deprecation_check
branch
from
dc5b592
to
9c96d84
Compare
|
Ok should be solid now. |
dopplershift
approved these changes
Sep 29, 2018
|
To be clear, this doesn't require a new pytest plugin? |
|
I does not appear to in my testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will check for MetPy deprecation warnings to ensure we don't ship things calling deprecated code. Closes #934. Will need to be merged after the rest of the 0.9.2 related items.