Fix crash with mixed-layer LFC calculation #961
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a crash when computing the LFC of a mixed-layer parcel and adds a corresponding test for this situation. A different test breaks with this change since the LCL is computed based on the parcel profile rather than the actual temperature, which I think is correct, but need to verify further.
dopplershift
added
Type: Bug
Picked up by pydocstyle 3.0.
The warning was blaming Pint, but it was actually coming from this code.
flake8 is picking up this file now, might as well make it compliant.
Can't use raw strings since we need \n and \r, so need to use \\ for the regular expression groups.
Matplotlib 3.0.1 has been released.
Add support for drawing SkewT on an axes at an arbitrary location.
Scipy 1.2 fixed a bug in 2D cubic interpolation, so we need to adjust the values in the sample files. We can avoid shipping mulitple versions of the static data by skipping the tests on older Scipy versions.
This commit adds the .loc indexer and .sel method to both the DataArray
and Dataset metpy accessors to allow for unit-aware indexing/selection.
For DataArrays (for which axis types are uniquely determined), this also
allows selection via the axis name ('time', 'vertical', etc.) instead of
the coordinate name.
Also, adds this new unit-aware selection to the xarray tutorial.
Previously, any existing axis attribute was removed to enforce uniqueness of any given axis, but this modified the user's data. Now, the axis is tracked in _metpy_axis to avoid collisions.
As discussed in Unidata#949, the error message from the cross section function could be made clearer in the case where coordinate information is missing. This catches the AttributeError that was raised and instead raises a more informative error. The docstrings have also been updated.
Adds a declarative interface for creating plots, similar in nature to GEMPAK.
Seems a bit clearer.
This has completely busted us.
|
I finally came back to this, found an error in my fix, and have fixed it. All tests are passing as far as I can tell, and #945 seems to be fixed. |
|
This PR has a bug. Will fix momentarily. |
|
Closing in favor of #1022 . (If this is a mistake, feel free to re-open.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #945 although this is a work in progress. A test breaks, but I need to check if the test is correct or if it needs to be changed to match the output this PR generates.