Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change XArray projection warning to a logged message #976

Merged
merged 2 commits into from Dec 10, 2018

Conversation

vardan10
Copy link
Contributor

@vardan10 vardan10 commented Dec 7, 2018

Using log.warning instead of warnings.warn

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@jrleeman jrleeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Here's what CI is complaining about

/home/travis/build/Unidata/MetPy/metpy/xarray.py:9:1: I100 Import statements are in the wrong order. 'import functools' should be before 'import logging'
/home/travis/build/Unidata/MetPy/metpy/xarray.py:9:1: I202 Additional newline in a group of imports. 'import functools' is identified as Stdlib and 'import logging' is identified as Stdlib.

The import block should look like this to calm it down:

import functools
import logging
import re
import warnings

@jrleeman jrleeman changed the title Fixes #974 Change XArray projection warning to a logged message Dec 7, 2018
@dopplershift dopplershift added this to the 0.10 milestone Dec 7, 2018
Copy link
Contributor

@jrleeman jrleeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any objections to going forward with this @dopplershift ?

@dopplershift dopplershift merged commit 94bd417 into Unidata:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants