Set __module__ for exported functions. #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Area: Infrastructure
jrleeman
suggested changes
Dec 18, 2018
There was a problem hiding this comment.
Just some flake things, but otherwise I'm good with this:
____________________ FLAKE8-check(ignoring F405 W503 D999) _____________________
/home/travis/build/Unidata/MetPy/metpy/plots/__init__.py:25:5: F401 '.cartopy_utils.USCOUNTIES' imported but unused
/home/travis/build/Unidata/MetPy/metpy/plots/__init__.py:25:5: F401 '.cartopy_utils.USSTATES' imported but unused
_______________________ FLAKE8-check(ignoring F405 W503) _______________________
/home/travis/build/Unidata/MetPy/metpy/plots/_util.py:20:1: E302 expected 2 blank lines, found 1
_______________________ FLAKE8-check(ignoring F405 W503) _______________________
/home/travis/build/Unidata/MetPy/metpy/tests/test_packaging.py:11:1: E302 expected 2 blank lines, found 1
/home/travis/build/Unidata/MetPy/metpy/tests/test_packaging.py:11:1: D103 Missing docstring in public function
|
😡 I was running flake8 regularly here to try to avoid this. And apparently did not do it on the last iteration. |
dopplershift
force-pushed
the
set-module
branch
from
8b25a57
to
16ae341
Compare
|
Alright, cleaned up. |
jrleeman
suggested changes
Dec 19, 2018
There was a problem hiding this comment.
3.6 docs are failing with this and similar (I already kicked the build once)
________________ [doctest] metpy.interpolate.log_interpolate_1d ________________
EXAMPLE LOCATION UNKNOWN, not showing all tests of that example
??? >>> x_log = np.array([1e3, 1e4, 1e5, 1e6])
UNEXPECTED EXCEPTION: NameError("name 'np' is not defined",)
Traceback (most recent call last):
File "/opt/python/3.6.7/lib/python3.6/doctest.py", line 1330, in __run
compileflags, 1), test.globs)
File "<doctest metpy.interpolate.log_interpolate_1d[0]>", line 1, in <module>
NameError: name 'np' is not defined
|
Weird. Importing numpy within the |
dopplershift
force-pushed
the
set-module
branch
2 times, most recently
from
fe0a7f9
to
1f508bd
Compare
This causes the functions to show up under the proper namespace, rather than the original module, when printed in IPython/notebook.
Not sure why this PR necessitates this, but these additions are fine.
dcamron
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #968. Resets the
__module__on our exported functions so that they appear from the proper namespace when printed in IPython/Jupyter notebook. Also fixes a couple places where we were incorrectly putting the objects themselves, rather than their names, into__all__. (Found because those cases break this new code.)