Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDUNITS-2 Cmake/Visual Studio build broken. #40

Closed
WardF opened this issue Oct 22, 2015 · 3 comments
Closed

UDUNITS-2 Cmake/Visual Studio build broken. #40

WardF opened this issue Oct 22, 2015 · 3 comments

Comments

@WardF
Copy link
Member

WardF commented Oct 22, 2015

In the course of answering a question re: UDUNITS-2 Issue #16, I've discovered that the latest code in master fails to compile on Windows with Visual Studio. The culprit is the auto-generated file scanner.c, which has introduced a dependency on unistd.h. This issue is clearly known on other platforms, as a lack of unistd.h has been mitigated in autotools-based builds.

The fix should be fairly simple; I forked and took a quick pass, but the fix I added didn't work as expected. I will pursue as best I can, although my focus right now is on some netcdf-c issues.

@ocefpaf
Copy link
Contributor

ocefpaf commented Oct 22, 2015

@WardF it will be awesome to get rid of a bogus dependency. Meanwhile we are building on windows by copying an empty file named unistd.h to the build directory.

(See https://github.com/ocefpaf/conda-recipes/blob/master/udunits2/bld.bat#L14)

@WardF
Copy link
Member Author

WardF commented Oct 22, 2015

I've addressed this issue in #41. I don't have access to merge the pull request, and even if I did, the project maintainer is @semmerson so I'd want him to review it first. But, once reviewed, it can be merged.

The changes were tested in Windows 10 (64-bit) with Visual Studio 12. Testing was also performed on the latest OSX, and a Ubuntu 15.10 environment.

@semmerson
Copy link
Collaborator

Looks good. I merged and pushed to GitHub. Hopefully, a new release will be out by COB tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants