Visual Studio Fix, RPATH handling improvement #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f it is not found or available.
…and also handles a few corner cases in Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected an issue I reported in UDUNITS-2 #40, e.g. Visual-Studio based Windows builds were broken due to a dependency on unistd.h introduced by flex. This issue was corrected in CMake-based builds, as these are the only type of builds on Windows that use Visual Studio.
I also added some cmake configuration for handling RPATH values post-install. This squelches an OSX-specific cmake warning that was being reported, and addresses some linux corner cases.