We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In function NC4_inq_type_equal(), there is this code:
/* Are the two types equal? */ if (equalp) *equalp = (int)H5Tequal(type1->native_hdf_typeid, type2->native_hdf_typeid);
However, when H5Tequal() returns an error (-1) hilarious confusion will ensue.
The return value of H5Tequal() needs to be checked, and NC_EHDFERR returned if it fails.
Note that in these cases, nc_inq_type_equal() will get an incorrect result, -1, which the user will interpret as equal.
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
In function NC4_inq_type_equal(), there is this code:
However, when H5Tequal() returns an error (-1) hilarious confusion will ensue.
The return value of H5Tequal() needs to be checked, and NC_EHDFERR returned if it fails.
Note that in these cases, nc_inq_type_equal() will get an incorrect result, -1, which the user will interpret as equal.
The text was updated successfully, but these errors were encountered: