Test code for parallel I/O issue, enum issue, and some other issues #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffle are turned on
edhartnett
changed the title
|
@WardF can I get this merged soon? I am basing the vars parallel I/O tests and work on some work in this branch, so it would be easiest if it were merged before I present the next PR. |
|
It will probably be next week before I circle back around to code review and merging; I'll try to make it earlier in the week. |
|
@WardF can we get this merged soon? There is a large backlog of code changes that I have piled up. It would be nice to get them merged and move on to new work. Thanks. |
|
I'll take a look at it early this week; there is other work going on that needs my attention at the moment. |
|
Reviewing now. |
|
Thanks @WardF , next PR is up. ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #978.
Fixes #985.
Part of #679.
Fixes #993.
Fixes #710.
This is a combined PR.
This PR contains mostly new test code. It contains new parallel I/O tests which are important. We believe we have found a bug in HDF5 1.10.1 and 1.10.2 parallel I/O related to collective writes in which some processes have a count of 0. The tests in this PR are an important part of narrowing in on this bug.
Also included are tests of the enum functionality when a fill value is not specified, or is not a valid member of the enum.
There are also some pre-approved, minor code changes, including checking of some return codes, and the removal of dead, legacy code that was never used (ex. HDF5_CONVERT code).