Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the NC_INMEMORY code to work in all cases with HDF5 1.10. #1133

Merged
merged 1 commit into from
Sep 5, 2018

Conversation

DennisHeimbigner
Copy link
Collaborator

re: github issue #1111

One of the less common use cases for the in-memory feature is
apparently failing with HDF5-1.10.x. The fix is complicated and
requires significant changes to libhdf5/nc4memcb.c. The current
setup is detailed in the file docs/inmeminternal.dox.

Additionally, it was discovered that the program
nc_test/tst_inmemory.c, which is invoked by
nc_test/run_inmemory.sh, actually was failing because of the
above problem. But the failure is not detected since the script
does not return non-zero value.

Other Changes:

  1. Fix nc_test_tst_inmemory to return errors correctly.
  2. Make ncdap_tests/findtestserver.c and dap4_tests/findtestserver4.c
    be generated from ncdap_test/findtestserver.c.in.
  3. Make LOG() print output to stderr instead of stdout to
    avoid contaminating e.g. ncdump output.
  4. Modify the handling of NC_INMEMORY and NC_DISKLESS flags
    to properly handle that NC_DISKLESS => NC_INMEMORY. This
    affects a number of code pieces, especially memio.c.

re: github issue #1111

One of the less common use cases for the in-memory feature is
apparently failing with HDF5-1.10.x.  The fix is complicated and
requires significant changes to libhdf5/nc4memcb.c. The current
setup is detailed in the file docs/inmeminternal.dox.

Additionally, it was discovered that the program
nc_test/tst_inmemory.c, which is invoked by
nc_test/run_inmemory.sh, actually was failing because of the
above problem. But the failure is not detected since the script
does not return non-zero value.

Other Changes:
1. Fix nc_test_tst_inmemory to return errors correctly.
2. Make ncdap_tests/findtestserver.c and dap4_tests/findtestserver4.c
   be generated from ncdap_test/findtestserver.c.in.
3. Make LOG() print output to stderr instead of stdout to
   avoid contaminating e.g. ncdump output.
4. Modify the handling of NC_INMEMORY and NC_DISKLESS flags
   to properly handle that NC_DISKLESS => NC_INMEMORY. This
   affects a number of code pieces, especially memio.c.
@WardF WardF added this to the 4.7.0 milestone Sep 4, 2018
@WardF WardF self-assigned this Sep 4, 2018
@WardF WardF merged commit d62a9e6 into master Sep 5, 2018
@DennisHeimbigner DennisHeimbigner deleted the inmemory10.dmh branch September 11, 2018 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants