Ignore NC_MPIIO and NC_MPIPOSIX #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix bug when NC_check_id() failed, nc should not be used.
using NC_MPIIO or NC_MPIPOSIX explicitly is not necessary. These 2 subroutines call NC_create() and NC_open() with argument useparallel set to 1, which should be used to tell which I/O driver to use underneath.
1. When model is detected as NC_FORMATX_NC3 and is called from nc_create_par, change the model to NC_FORMATX_PNETCDF. 2. When called from nc_create() or nc_open(), using NC_MPIIO or NC_MPIPOSIX is considered invalid. 3. Handle the case when NETCDF4 is not enabled but cmode/omode contains NC_NETCDF4. 4. Handle the case when PNETCDF is not enabled but cmode/omode contains NC_PNETCDF. 5. Correct comments about PnetCDF only handles CDF-5 files. 6. Add a check for MPI_ERR_NO_SUCH_FILE error class. Make NC_check_file_type() static, as it is used in dfile.c only.
enabled but NC_PNETCDF is used in cmode or omode.
parallel netcdf4. Also, update PnetCDF web page.
tst_pnetcdf.nc generated from tst_pnetcdf.c.
wkliao
force-pushed
the
nc_mpiio_nc_mpiposix
branch
from
615dcc9
to
a7c08c3
Compare
DennisHeimbigner
approved these changes
Oct 9, 2018
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ignores flags NC_MPIIO and NC_MPIPOSIX, as discussed in #1145.
It was developed on top of PR #1143.