CMakeLists.txt: Fix compilation with default settings on debian stretch #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 209c31d (Bringing config.h as generagted by cmake in line with config.h as generated by autotools., 2017-01-27) we check that we can find the hdf5.h main include file. But this file may reside in non-standard location so we have to search in HDF5_INCLUDE_DIR as well.
|
Looks great, thanks! Will merge this soon, when I turn my attention back to managing pull requests. |
|
@WardF configure has the same problem. I'm unable to propose a patch but a workaround is posted in #1216 (comment). |
|
Not sure what the autotools problem is supposed to be. Setting flags as is standard seems to work fine, including setting location of hdf5 in CPPFLAGS and LDFLAGS. What am I missing? |
|
@edhartnett |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 209c31d (Bringing config.h as generagted by cmake in line with config.h as generated by autotools., 2017-01-27)
we check that we can find the hdf5.h main include file.
But this file may reside in non-standard location so we have to search
in HDF5_INCLUDE_DIR as well.