Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support installation of the bzip2 plugin under name libh5bzip2.so #1348

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

DennisHeimbigner
Copy link
Collaborator

re: #1347

It turns out that the plugin libraries (bzip2 and misc) were
being installed as part of 'make install'. This was not intended
behavior. But after some discussion in the above issue, it was decided
to install the bzip2 plugin. However, in order to avoid naming conflicts,
the plugin is installed under the name 'libh5bzip2.so'.
Note that this is automake behavior only; the install does not
(yet) occur using cmake.

Misc. unrelated changes

  1. turn off some debug output in ncdump/Makefile.am

re: #1347

It turns out that the plugin libraries (bzip2 and misc) were
being installed as part of 'make installed'. This was not intended
behavior. But after some discussion in the above issue, it was decided
to install the bzip2 plugin. However, in order to avoid naming conflicts,
the plugin is installed under the name 'libh5bzip2.so'.
Note that this is automake behavior only; the install does not
(yet) occur using cmake.

Misc. unrelated changes
-----------------------
1. turn off some debug output in ncdump/Makefile.am
@edhartnett
Copy link
Contributor

In your plugins, do you have a full implimentation of szip library?

If so, should this just be something we require at configure and not ship it?

@DennisHeimbigner
Copy link
Collaborator Author

DennisHeimbigner commented Feb 27, 2019

In your plugins, do you have a full implementation of szip library?

You said szip; I assume you mean bzip2. And yes, there is complete bzip2
compress/decompress code in the plugins directory and is part of the
distribution.

@opoplawski
Copy link
Contributor

Plugins (i.e. dlopened libraries) should not be installed in $libdir, but in something like ${libdir}/netcdf - i.e. a custom directory for plugins.

@DennisHeimbigner
Copy link
Collaborator Author

Good idea; then we can avoid using a weird name for the plugin.

@WardF
Copy link
Member

WardF commented Sep 16, 2019

Thanks @opoplawski, I agree with @DennisHeimbigner . We will see what we can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants