Allow building with hdf5-1.12.x without having to set HDF5 compatibility... #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WardF I think you will want to merge this change before the 4.8.1 release... |
|
Awesome! |
|
This looks nearly too good to be true, but the tests are passing and there surely can't be any blind spots there ¯_(ツ)_/¯. Thanks @edhartnett this looks great, it will go into the 4.8.1 release, and thanks @ArchangeGabriel as well! |
WardF
approved these changes
Aug 5, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1965
Fixes #2026
This was shockingly easy to fix! Thanks to @ArchangeGabriel for your help on this one.
Once this is done, we will not have to tell anyone to build with any HDF5 API compatibility layer - the vanilla, out of the box, HDF5 build will work. ;-) And we can start taking a better look at some of those sweet new HDF5-1.12.x features...