Fixed Clang -Wstrict-prototypes warnings

[seanm]

Clang is considering making this warning an error by default: https://discourse.llvm.org/t/rfc-enabling-wstrict-prototypes-by-default-in-c/60521

[CLAassistant]

All committers have signed the CLA.

[DennisHeimbigner]

There may be a problem here. The files ncgeny.c and others are generated
using bison. It is possible that some of the generated code violates
the strict prototype rule and we cannot fix this; it requires a change in bison.
Same for .l files and flex.

[seanm]

I changed the .l and .y files too, to match the changes I made in the .c files. It looks to me like regeneration would be ok, but I did not try.

[WardF]

@seanm thanks! @DennisHeimbigner that's a good point, I think I will add a one-off set of tests to the github actions file that explicitly regenerates those generated files we depend upon, to ensure that any changes to the .y files are also explicitly tested.

For this PR, I will pull the changes into a local branch, regenerate via bison and test by hand :).

Thanks again!

[WardF]

@seanm Are you able to sign the license agreement (CLA)?

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

[DennisHeimbigner]

It is probably ok. But bison and flex generate code (including prototypes) not
found in the .l or .y files.

[seanm]

@WardF did I sign it correctly? Anything else needed to get this merged?

[WardF]

You did, thank you!

[seanm]

Great, thanks. You might want to consider enabling this warning on your CI, if you have a clang that supports it...

[WardF]

Not a bad idea, thanks!