Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more old utf8 code #430

Merged
merged 4 commits into from
Jun 20, 2017
Merged

Remove more old utf8 code #430

merged 4 commits into from
Jun 20, 2017

Commits on Jun 6, 2017

  1. re: pull request #364

    This is a follow-on in that the old utf8 code was still being
    used in ncgen to convert utf8->utf16 when converting cdl to Java
    (see genj.c).
    
    The new code apparently has no utf16 support, but it does have
    utf32 support. Converting utf32 -> utf16 can be approximated by
    truncating the 32bits to 16 bits, unless the top 16 bits are
    not zero. This latter condition is unlikely to be common because
    it implies use of some rather obscure characters.
    
    So solution is to convert to utf32 and truncate to 16 bits to
    get utf16. An error is reported if the high-order truncated 16
    bits are not zero. If we get complaints, then I will figure out
    how to convert full utf32 to a utf16 pair.
    
    Also removed the old code from ncgen.
    DennisHeimbigner committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    8f2f9b7 View commit details
    Browse the repository at this point in the history
  2. Cmake

    DennisHeimbigner committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    30846cf View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2017

  1. Configuration menu
    Copy the full SHA
    e2e7c20 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2017

  1. re: pull request #364

    This is a follow-on in that the old utf8 code was still being
    used in ncgen to convert utf8->utf16 when converting cdl to Java
    (see genj.c).
    
    The new code apparently has no utf16 support, but it does have
    utf32 support. Converting utf32 -> utf16 can be approximated by
    truncating the 32bits to 16 bits, unless the top 16 bits are
    not zero. This latter condition is unlikely to be common because
    it implies use of some rather obscure characters.
    
    So solution is to convert to utf32 and truncate to 16 bits to
    get utf16. An error is reported if the high-order truncated 16
    bits are not zero. If we get complaints, then I will figure out
    how to convert full utf32 to a utf16 pair.
    
    Other changes:
    1. removed the old code from ncgen.
    2. changed UTF8PROC_DLLEXPORT (in utf8proc) to EXTERNL
       and added appropriate includes. This should fix
       issue #404,
       but since we cannot duplicate the failure, I am not quite
       sure.
    DennisHeimbigner committed Jun 19, 2017
    Configuration menu
    Copy the full SHA
    9cde916 View commit details
    Browse the repository at this point in the history