BUILD BUGFIX: Remove use of BUILT_SOURCES in ncdump directory... #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edhartnett
changed the title
This was referenced Nov 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incorrect handling of BUILT_SOURCES ctest.c and ctest64.c has been present in the library for at least a decade, since I put it there. ;-) So it's good to get a chance to clean it up.
Fixes #606.
In autotools terminology, "built sources" are source files that are built during configure, instead of shipped in the tarball. Their use introduces dependencies in testing order.
I have changed the ncdump testing so that we no longer need to use built sources. The same stuff is tested, but in a different way.
Current Behavior (with --enable-extra-tests):
Current Behavior (without --enable-extra-tests)"
(Note that this does not actually test ncgen/ncdump. It was just a hack to get around the BUILT_SOURCES problem.)
New behavior:
(Note that ctest.c is never built, but we know it would work because it's exactly the same as ref_ctest.c, which is built.)
This new behavior tests the same things, but without using built sources. This removed the dependency and simplifies both CMakeLists.txt and Makefile.am.
And this also fixes the BUILT_SOURCES problem that prevents make distcheck from working.
See #635 for in-depth discussion of ncdump test dependencies.