BUGFIX: fixed pnetcdf issues #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mine is also broken... |
Need to check the parameter stuff. See libsrc/nc3dispatch.c#NC3_inq_var_all for example
|
With respect to NOTNC4 stuff, you can look at the corresponding |
|
@gsjaardema do you use pnetcdf through netCDF? Or do you use pnetcdf directly? |
|
I use it through NetCDF |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #647.
Several fixes needed to get pnetcdf build working. @DennisHeimbigner please glance at the code and tell me if you think it is correct WRT the options_maskp argument. (I surmise that you took that out of the parameters and now pass it in with params in the HDF4 code?)
Also had to add the new nc_def_var_filter() function to the dispatch table for pnetcdf.
@WardF please make this PR a priority since my pnetcdf CI build will be broken until this is merged. I believe there is no other pnetcdf CI build at the moment.