Cause nc_create() to return NC_ENOTBUILT if user requests un-built feature like netCDF4 or CDF5 #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edhartnett
changed the title
|
@WardF and @DennisHeimbigner you guys OK with these changes? If so I will merge this PR into my next mega-PR. |
|
Looks good to me, what do you think @DennisHeimbigner? |
|
I am ok with it. |
|
OK, I will merge this into my other open PR so they can be done at the same time. Thanks! |
|
I have merged this into #711. I will take this PR down now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #392.
This PR changes some behavior. Incorrect create mode flags that were previously ignored will now trigger errors.
For example, attempting to use NC_NETCDF4 in a library built with --disable-netcdf4 will currently be ignored. A classic file will be created.
After this PR, an NC_ENOTBUILT error is returned instead.
I am not married to these changes, I only put them in in response to user ticket and discussion. So if you don't want to make this change, just explain that in #392 and close the ticket.
This PR was inadvertantly closed when my last batch of changes were merged, but these changes were not part of that batch. I want to make sure that @WardF and @DennisHeimbigner have a good understanding of how library behavior will change with this PR.