Ncf 177 #8
Merged
Ncf 177 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Also many cleanups to fix compiler warnings, streamline iteration over objects in HDF5 file when opening the file, and generally straightening out the code to be cleaner and simpler. Tested on Mac OS/X with gcc 4.8 and OpenMPI (which uses clang).
|
|
||
| if (H5Gget_objinfo(did, ".", 1, &statbuf) < 0) ERR; |
There was a problem hiding this comment.
Just reviewing some changes in the test code, and it's not clear why this line was deleted.
Was it deleted because it was
- a correct test implemented incorrectly?
- an unnecessary test, because logically the failure could not occur?
- a test that is expected to fail?
- a test that failed, but the failure would also be caught by a later test?
- for some other reason?
|
That call to H5Gget_objinfo() retrieved the information for the dataset that the dimscale is attached to, but never used the information (in statbuf), so I eliminated the dead code (call to H5Gget_objinfo). |
edhartnett
added a commit
to NetCDF-World-Domination-Council/netcdf-c
that referenced
this pull request
Jan 31, 2018
…_gitignore Ejh gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address NCF-177, plus other code cleanups, simplifications and optimizations.
Tested on Mac OSX 10.9.0 with gcc 4.8.2 and also with OpenMPI (using clang)