The ncdap_tests were a mess, so I decided to clean them up #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to remove cruft and to remove unused site tests and make the tests somewhat more understandable. Also did a fix to libdispatch/dwinpath to convert relative paths to absolute paths. This will, I hope, take care of some windows path problems when using $srcdir in shell scripts.
WardF
approved these changes
Mar 26, 2018
|
I'm seeing errors from |
|
I just ran it again on my laptop (cygwin) and it ran ok. |
|
So it is only failing on OSX for me, let me take a quick look to rule out anything environmental. |
|
It is probably a bash script problem again; maybe a path. |
|
It appears to actually be a cmake issue on OSX; if I reduce the number of parallel threads, everything passes. The failures I'm observing were actually in cmake itself, not the underlying tests. |
|
The issue is occurring on other branches as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed cruft and removed unused site tests
and made the tests somewhat more understandable.
Also did a fix to libdispatch/dwinpath to convert
relative paths to absolute paths. This will, I hope,
take care of some windows path problems when using
$srcdir in shell scripts.